Vendor solhint-config-keep/eslint-config-keep/prettier-config-keep - #194
Open
piotr-roslaniec wants to merge 1 commit into
Open
piotr-roslaniec wants to merge 1 commit into
piotr-roslaniec wants to merge 1 commit into
Conversation
Removes github: protocol dependencies on keep-network/solhint-config-keep, keep-network/eslint-config-keep, and keep-network/prettier-config-keep, replacing them with vendored .solhint.json/.eslintrc/.prettierrc.js content plus explicit pinned devDependencies for the transitive packages (eslint-config-google, eslint-config-prettier, eslint-plugin-no-only-tests, eslint-plugin-prettier) that were previously pulled in only via eslint-config-keep's own dependencies. This removes the git-protocol dependency fragility (unauthenticated git: protocol, upstream repo availability) from this repo's install. npm run lint (eslint . then solhint 'contracts/**/*.sol') verified clean before and after this change, confirming zero behavioral change.
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendors
solhint-config-keep,eslint-config-keep, and@keep-network/prettier-config-keepinto this repo's root, removing thegithub:protocol dependency onkeep-network/solhint-config-keep,keep-network/eslint-config-keep, andkeep-network/prettier-config-keep. These repos are fetched over the unauthenticatedgit:/github:protocol at install time, which is fragile (upstream availability, rate limits, protocol deprecation) compared to a normal registry dependency..eslintrc,.prettierrc.js, and.solhint.jsonnow contain the inlined rules/config instead ofextends/require-ing the external packages.eslint-config-keep's own transitive dependencies (eslint-config-google,eslint-config-prettier,eslint-plugin-no-only-tests,eslint-plugin-prettier) are added back as explicit pinneddevDependencies, since they were previously pulled in only via its owndependenciesblock.This repo's local overrides are preserved:
max-states-countstays bumped to 20 (vs. the shared default of 15), andno-inline-assemblystays fullyoff.Verification
npm run lint(eslint .thensolhint 'contracts/**/*.sol') was run after this change and both are clean (exit 0, no problems reported), matching the pre-change baseline. No behavioral change to linting itself; only the dependency source changes.Related
Companion PR in
tbtc-v2: threshold-network/tbtc-v2#1144Not in scope
Archiving the now-possibly-unreferenced
keep-network/solhint-config-keep,keep-network/eslint-config-keep,keep-network/prettier-config-keeprepos — separate decision, not attempted here.