Skip to content

feat(pr-review): integrate independent review context reads - #5699

Closed
iscekic wants to merge 4 commits into
mobile-pr-review-context-5458-s8from
mobile-pr-review-context-5458-s9
Closed

iscekic wants to merge 4 commits into
mobile-pr-review-context-5458-s8from
mobile-pr-review-context-5458-s9

Conversation

@iscekic

@iscekic iscekic commented Aug 29, 2026 •

Copy link
Copy Markdown
Collaborator
  • Pull request context now includes GitHub review decisions and recent review activity, separate from outstanding review requests.
  • If GitHub returns conflicting review details, the affected decision remains uncertain even when later responses omit those details.
  • If the pull request changes during loading, review decisions become outdated while review activity remains available.

Summary

getPullRequestContext now populates reviewDecisions and reviewActivity; this level changes backend responses, not mobile presentation.
latestOpinionatedReviews and latestReviews paginate independently within the existing ten-second deadline and four-request concurrency limit; confirmed empty traversals report complete collections.
The reader decodes state, submittedAt, and onBehalfOf errors separately, preserving field-level uncertainty and attribution provenance for callers.

Files
  • apps/web/src/lib/github-pr-review/context-reader.ts — Modified; 145 changed lines. Adds review pagination with identifier deduplication, per-field decoding, retained conflict evidence, and revision checks for decisions.
  • apps/web/src/lib/github-pr-review/context-people.test.ts — Modified; 28 changed lines. Allows only registered sibling queries, mocks router dependencies, and preserves six people-page requests without per-person lookups.

readPullRequestContext gives resolveContextReviewDecisions genuine conflictingReviewIds; unavailable fields alone do not establish contradictions.
It retains state, timestamp, and commit contradictions across pages, connections, null observations, and source failures, producing partial, retryable UNKNOWN decisions with review-inconsistent.
Source error metadata stays intact unless genuine conflicts require review-inconsistent; comparison evidence cannot fill null public submittedAt or commitSha values.

Files
  • apps/web/src/lib/github-pr-review/context-reviews-integration.test.ts — Added; 551 lines. Covers empty reviews, independent pagination, null observations, retained conflicts, sibling failures, completion order, and revision changes.

reviewDecisions now joins the revision fence for requirements, checks, and queue data, preventing changed pull requests from presenting decisions as current.
If revision checks fail, reviewDecisions.completeness becomes unknown; mismatches set stale availability, while missing or failed reads set unavailable or denied.
reviewActivity keeps its records, while issues, requirements, checks, and queue still have no readers attached by this level.

Files
  • apps/web/src/routers/github-pr-review-router.test.ts — Modified; 20 changed lines. Supplies both review connections, checks confirmed empty collections, and includes review decisions in revision-mismatch assertions.

Tests: 1 file added — context-reviews-integration.test.ts; 2 files updated — context-people.test.ts, github-pr-review-router.test.ts (3 total).
Generated: 0 files.


Visual Changes

Visual Changes: N/A

Verification

No manual provider, backend, or iOS feature scenario has run for this level.
The owner prohibits new end-to-end (E2E) slots and bundles.
Live backend and iOS verification waits for the completed stack tip.

Reviewer Notes

Human steps

No deployment, migration, or configuration step is known for these level-specific diffs.
The owner retains product merge authority.

  • before merge: When the owner permits runtime work, complete live backend and iOS feature verification on the completed stack tip.
  • before merge: Complete each level's current-head continuous integration (CI), bot, thread, and final description gates.
  • before merge: Do not ask for review or merge before the complete-stack human-ready gate.

No after-merge step is known for this level.

Historical automated proof

  • The level-9 metadata-reader repair preserved 27 baseline cases and added 48 cases; all 75 integration cases and five scoped checks passed.
  • Its fresh review returned No findings. before publication.
  • These results precede this refresh; no generation-20 product checks ran.
  • Historical proof does not establish current-head readiness or a completed runtime gate.

Scope and evidence

  • Repository: Kilo-Org/cloud; worktree: /Users/igor/Projects/.worktrees/mobile-pr-review-context-5458.
  • This description covers only mobile-pr-review-context-5458-s8...mobile-pr-review-context-5458-s9.
  • Reviewed base: 627b0870a13c438f3af01b84ac17e142784fdb85; reviewed head: 0996ef8679fcaba45b8f6025b934808298e162e2.
  • The frozen source HEAD and the owner's uncommitted callback patch are outside this review.
  • All 27 existing pull requests remain part of one incomplete stack.
  • Synthetic fixtures test conservative handling of returned evidence, not undocumented provider transitions.

Notes

This level attaches review context reads. Live backend and iOS verification will run on the completed stack tip.

Live backend and iOS feature verification remains required on the completed stack tip.

The owner currently prohibits new E2E slots and bundles; this hold does not waive runtime verification.

Levels 24 and 25 have prepared repairs and partial proof, but publication remains pending a workflow operation for an unpublished propagated baseline.

Their required three-root type checks have not passed; no failed publication proof is applied.

The owner descoped large-text/font-scaling, theme variants, contrast rendering, scaled-text layout, and screen-reader presentation.

Functional accessibility labels, roles, identifiers, selectors, default appearance flows, and all non-visual criteria remain required.

This is an interim description refresh; the complete-stack readiness gate remains open.

Stacked PRs — merge bottom to top. Each level shows only its own diff.

Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.

  1. mobile-pr-review-context-5458-s1 — ci(pr-review): enable checks for context stack bases #5679
  2. mobile-pr-review-context-5458-s2 — feat(pr-review): define source-backed context contracts #5682
  3. mobile-pr-review-context-5458-s3 — feat(pr-review): normalize optional context payloads #5684
  4. mobile-pr-review-context-5458-s4 — feat(pr-review): map available REST context metadata #5687
  5. mobile-pr-review-context-5458-s5 — feat(pr-review): isolate optional context reads #5690
  6. mobile-pr-review-context-5458-s6 — feat(pr-review): complete labels and requested people #5691
  7. mobile-pr-review-context-5458-s7 — feat(pr-review): define review source documents and normalization #5695
  8. mobile-pr-review-context-5458-s8 — feat(pr-review): select source-backed review decisions #5696
  9. mobile-pr-review-context-5458-s9 — feat(pr-review): integrate independent review context reads #5699 ← this PR
  10. mobile-pr-review-context-5458-s10 — test(pr-review): preserve review source failure coverage #5703
  11. mobile-pr-review-context-5458-s11 — feat(pr-review): define linked issue source contracts #5706
  12. mobile-pr-review-context-5458-s12 — feat(pr-review): integrate typed linked issue context #5707
  13. mobile-pr-review-context-5458-s13 — test(pr-review): cover linked issue source failures #5708
  14. mobile-pr-review-context-5458-s14 — feat(pr-review): preserve structured policy evidence #5709
  15. mobile-pr-review-context-5458-s15 — feat(pr-review): normalize applicable merge policies #5712
  16. mobile-pr-review-context-5458-s16 — feat(pr-review): read applicable merge policies #5713
  17. mobile-pr-review-context-5458-s17 — feat(pr-review): define requirement observation contracts #5720
  18. mobile-pr-review-context-5458-s18 — feat(pr-review): expand named policy requirements #5723
  19. mobile-pr-review-context-5458-s19 — feat(pr-review): evaluate evidenced check requirements #5727
  20. mobile-pr-review-context-5458-s20 — feat(pr-review): evaluate evidenced merge policies #5728
  21. mobile-pr-review-context-5458-s21 — test(pr-review): preserve check evaluation coverage #5730
  22. mobile-pr-review-context-5458-s22 — test(pr-review): preserve policy evaluation coverage #5732
  23. mobile-pr-review-context-5458-s23 — feat(pr-review): integrate requirement observation reads #5735
  24. mobile-pr-review-context-5458-s24 — test(pr-review): preserve requirement source coverage #5736
  25. mobile-pr-review-context-5458-s25 — test(pr-review): complete requirement reader coverage #5739
  26. mobile-pr-review-context-5458-s26 — feat(pr-review): preserve queue membership and position #5741
  27. mobile-pr-review-context-5458-s27 — refactor(pr-review): share mobile-safe context contracts #5744 (tip)

@kilo-code-bot

kilo-code-bot Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • apps/web/src/lib/github-pr-review/context-reader.ts
  • apps/web/src/lib/github-pr-review/context-reviews-integration.test.ts
Previous Review Summary (commit c405d42)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit c405d42)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • apps/web/src/lib/github-pr-review/context-reader.ts
  • apps/web/src/lib/github-pr-review/context-reviews-integration.test.ts
  • apps/web/src/lib/github-pr-review/context-people.test.ts
  • apps/web/src/routers/github-pr-review-router.test.ts

Reviewed by grok-4.6 · Input: 207.2K · Output: 16.9K · Cached: 286.8K

Review guidance: REVIEW.md from base branch mobile-pr-review-context-5458-s8

@iscekic

iscekic commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Closing: the owner stopped this workflow section. The branch is retained.

@iscekic iscekic closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant