test(pr-review): preserve requirement source coverage

[iscekic]

No new behavior — this change adds tests for existing review behavior.

---

Summary

readPullRequestContext gains regression coverage for evidence boundaries without changing its runtime contract. The tests isolate errors on requiredStatusCheckContexts and isResolved, reject requirements inferred from mergeStateStatus, and distinguish trustworthy headRefOid mismatches from field errors. Only trustworthy evaluation mismatches mark requirements stale with revision-mismatch; errored revision fields cannot invalidate independent review context.

Files

• apps/web/src/lib/github-pr-review/context-rules-integration.test.ts — adds checks for policy, thread, merge-state, and revision evidence. Denied check policies keep conversation resolution met and labels complete; branch freshness and check requirements become unavailable. Both errored thread states make conversation resolution unavailable without an unresolved-thread count. Confirmed policy absence stays empty and complete for BLOCKED and UNSTABLE. A trustworthy evaluation mismatch invalidates all requirements despite matching outer revision reads. An errored revision leaves requirements unavailable without staleness, checks partial and non-retryable, review decisions available, and labels complete.

Tests: 1 test file modified (M), context-rules-integration.test.ts: 137 insertions, 0 deletions; 41,571 bytes at the review head.
Generated: 0 files changed.

---

Visual Changes

Visual Changes: N/A

Verification

• Manual testing: not run for this description; this level restores tests without changing production behavior.

Reviewer Notes

• Review scope: level 24, from mobile-pr-review-context-5458-s23 to mobile-pr-review-context-5458-s24.
• Repository: Kilo-Org/cloud. Worktree: /Users/igor/Projects/.worktrees/mobile-pr-review-context-5458.
• This update does not rerun product tests; the previous handoff supplies the automated result.
• Automated verification (handoff): All 115 integration tests, scoped lint, formatting, and whitespace checks passed.

Human steps

This change requires no human steps before merge or after merge.

Notes

Live backend and iOS verification remains pending on the completed stack tip.

• Levels 24 and 25 are prepared and proved but unpublished, pending a workflow operation that applies an owning repair to an unpublished propagated baseline.
• This note concerns the prepared repairs, not the existing feature commits.
• Owning and cumulative tests and scoped formatting pass for the prepared repair snapshots; type and publication gates remain incomplete.
• Runtime verification has not run; backend and iOS verification remain required before complete-stack readiness.
• Owner-descoped: large text/font scaling, theme variants, contrast rendering, scaled-text layout, and screen-reader presentation checks.
• Functional accessibility labels, roles, identifiers, selectors, default appearance, and all non-visual criteria remain required.

Stacked PRs — merge bottom to top. Each level shows only its own diff.

Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.

1. mobile-pr-review-context-5458-s1 — ci(pr-review): enable checks for context stack bases #5679
2. mobile-pr-review-context-5458-s2 — feat(pr-review): define source-backed context contracts #5682
3. mobile-pr-review-context-5458-s3 — feat(pr-review): normalize optional context payloads #5684
4. mobile-pr-review-context-5458-s4 — feat(pr-review): map available REST context metadata #5687
5. mobile-pr-review-context-5458-s5 — feat(pr-review): isolate optional context reads #5690
6. mobile-pr-review-context-5458-s6 — feat(pr-review): complete labels and requested people #5691
7. mobile-pr-review-context-5458-s7 — feat(pr-review): define review source documents and normalization #5695
8. mobile-pr-review-context-5458-s8 — feat(pr-review): select source-backed review decisions #5696
9. mobile-pr-review-context-5458-s9 — feat(pr-review): integrate independent review context reads #5699
10. mobile-pr-review-context-5458-s10 — test(pr-review): preserve review source failure coverage #5703
11. mobile-pr-review-context-5458-s11 — feat(pr-review): define linked issue source contracts #5706
12. mobile-pr-review-context-5458-s12 — feat(pr-review): integrate typed linked issue context #5707
13. mobile-pr-review-context-5458-s13 — test(pr-review): cover linked issue source failures #5708
14. mobile-pr-review-context-5458-s14 — feat(pr-review): preserve structured policy evidence #5709
15. mobile-pr-review-context-5458-s15 — feat(pr-review): normalize applicable merge policies #5712
16. mobile-pr-review-context-5458-s16 — feat(pr-review): read applicable merge policies #5713
17. mobile-pr-review-context-5458-s17 — feat(pr-review): define requirement observation contracts #5720
18. mobile-pr-review-context-5458-s18 — feat(pr-review): expand named policy requirements #5723
19. mobile-pr-review-context-5458-s19 — feat(pr-review): evaluate evidenced check requirements #5727
20. mobile-pr-review-context-5458-s20 — feat(pr-review): evaluate evidenced merge policies #5728
21. mobile-pr-review-context-5458-s21 — test(pr-review): preserve check evaluation coverage #5730
22. mobile-pr-review-context-5458-s22 — test(pr-review): preserve policy evaluation coverage #5732
23. mobile-pr-review-context-5458-s23 — feat(pr-review): integrate requirement observation reads #5735
24. mobile-pr-review-context-5458-s24 — test(pr-review): preserve requirement source coverage #5736 ← this PR
25. mobile-pr-review-context-5458-s25 — test(pr-review): complete requirement reader coverage #5739
26. mobile-pr-review-context-5458-s26 — feat(pr-review): preserve queue membership and position #5741
27. mobile-pr-review-context-5458-s27 — refactor(pr-review): share mobile-safe context contracts #5744 (tip)

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)

• apps/web/src/lib/github-pr-review/context-rules-integration.test.ts

---

_{Reviewed by grok-4.6 · Input: 140.9K · Output: 11.2K · Cached: 635.6K}

_{Review guidance: REVIEW.md from base branch mobile-pr-review-context-5458-s23}

[iscekic]

Closing: the owner stopped this workflow section. The branch is retained.