Conversation
This was referenced Aug 29, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 140.9K · Output: 17.5K · Cached: 311.3K Review guidance: REVIEW.md from base branch |
This was referenced Aug 29, 2026
Collaborator
Author
|
Closing: the owner stopped this workflow section. The branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new behavior — the work prepares linked-issue support without changing the mobile app.
Summary
PR_CONTEXT_ISSUE_QUERIESaddsPrReviewContextClosingIssuesandPrReviewContextIssueEventswithContextIssueEndpoint;PR_REVIEW_GRAPHQL_DOCUMENTSregisters both for validation without activating reads.contextIssueSchemavalidates issue and repository identity;contextIssueEventSchemamaps five event types into directedconnected,referenced, orduplicaterecords withremovedmarkers.Invalid
createdAtvalues and URLs becomenull, and endpoints remain nullable; validation coversConnectedEvent,DisconnectedEvent,CrossReferencedEvent,MarkedAsDuplicateEvent, andUnmarkedAsDuplicateEvent.Files
apps/web/src/lib/github-pr-review/context-issues.ts— Added (+104/-0 lines). Adds server-only queries with 100-item cursor pages, total counts, and the pull request identity. Closing references setuserLinkedOnly: false; both queries include issue numbers, titles, states, URLs, and repository names. Cross-reference selections also includereferencedAtandwillCloseTarget; normalization retainscreatedAt, not these two fields. Raw issue inputs omitrelationshipsand require nonemptyrepository.nameWithOwner; endpoints accept onlyIssue,PullRequest, ornull. Connected events mapsourcetosubject; cross-references retainsourceandtarget; duplicate events mapduplicatetocanonical. Event identifiers must be nonempty; disconnect and unmark events setremoved.apps/web/src/routers/github-pr-review-router.ts— Modified (+2/-0 lines). Imports the linked-issue queries and adds them to the document registry; existing routes and reader calls remain unchanged.apps/web/src/lib/github-pr-review/context-issues-schema.test.ts— Added (+145/-0 lines). Adds 134 direct normalization cases for the linked-issue schemas.apps/web/src/routers/github-pr-review-graphql-schema.test.ts— Modified (+2/-2 lines). Updates GraphQL schema validation coverage for the expanded document registry.Tests: 2 files changed:
context-issues-schema.test.tsadded andgithub-pr-review-graphql-schema.test.tsupdated; 134 direct normalization cases added.Generated: 0 files changed.
Visual Changes
Visual Changes: N/A
Verification
No manual tests ran for this level because it defines source contracts without connecting the reader or changing mobile presentation.
Provider, fixture, mobile, and runtime acceptance remain in their approved later phases.
Reviewer Notes
Human steps
No human steps are required before merge or after merge.
Scope and automated evidence
Kilo-Org/cloud; worktree:/Users/igor/Projects/.worktrees/mobile-pr-review-context-5458.mobile-pr-review-context-5458-s10tomobile-pr-review-context-5458-s11.Notes
This level defines linked-issue source contracts. Reader integration and live backend/iOS verification remain pending on the completed stack tip.
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
mobile-pr-review-context-5458-s1— ci(pr-review): enable checks for context stack bases #5679mobile-pr-review-context-5458-s2— feat(pr-review): define source-backed context contracts #5682mobile-pr-review-context-5458-s3— feat(pr-review): normalize optional context payloads #5684mobile-pr-review-context-5458-s4— feat(pr-review): map available REST context metadata #5687mobile-pr-review-context-5458-s5— feat(pr-review): isolate optional context reads #5690mobile-pr-review-context-5458-s6— feat(pr-review): complete labels and requested people #5691mobile-pr-review-context-5458-s7— feat(pr-review): define review source documents and normalization #5695mobile-pr-review-context-5458-s8— feat(pr-review): select source-backed review decisions #5696mobile-pr-review-context-5458-s9— feat(pr-review): integrate independent review context reads #5699mobile-pr-review-context-5458-s10— test(pr-review): preserve review source failure coverage #5703mobile-pr-review-context-5458-s11— feat(pr-review): define linked issue source contracts #5706 ← this PRmobile-pr-review-context-5458-s12— feat(pr-review): integrate typed linked issue context #5707mobile-pr-review-context-5458-s13— test(pr-review): cover linked issue source failures #5708mobile-pr-review-context-5458-s14— feat(pr-review): preserve structured policy evidence #5709mobile-pr-review-context-5458-s15— feat(pr-review): normalize applicable merge policies #5712mobile-pr-review-context-5458-s16— feat(pr-review): read applicable merge policies #5713mobile-pr-review-context-5458-s17— feat(pr-review): define requirement observation contracts #5720mobile-pr-review-context-5458-s18— feat(pr-review): expand named policy requirements #5723mobile-pr-review-context-5458-s19— feat(pr-review): evaluate evidenced check requirements #5727mobile-pr-review-context-5458-s20— feat(pr-review): evaluate evidenced merge policies #5728mobile-pr-review-context-5458-s21— test(pr-review): preserve check evaluation coverage #5730mobile-pr-review-context-5458-s22— test(pr-review): preserve policy evaluation coverage #5732mobile-pr-review-context-5458-s23— feat(pr-review): integrate requirement observation reads #5735mobile-pr-review-context-5458-s24— test(pr-review): preserve requirement source coverage #5736mobile-pr-review-context-5458-s25— test(pr-review): complete requirement reader coverage #5739mobile-pr-review-context-5458-s26— feat(pr-review): preserve queue membership and position #5741mobile-pr-review-context-5458-s27— refactor(pr-review): share mobile-safe context contracts #5744 (tip)