Skip to content

test(pr-review): cover linked issue source failures - #5708

Closed
iscekic wants to merge 3 commits into
mobile-pr-review-context-5458-s12from
mobile-pr-review-context-5458-s13
Closed

iscekic wants to merge 3 commits into
mobile-pr-review-context-5458-s12from
mobile-pr-review-context-5458-s13

Conversation

@iscekic

@iscekic iscekic commented Aug 29, 2026 •

Copy link
Copy Markdown
Collaborator

No new behavior — this level adds linked-issue regression tests only.


Summary

Linked-issue regressions cover removals, directed endpoints, pagination, partial history, denial, retry metadata, shared deadlines, and nullable links.
They assert reader results rather than mock calls or implementation constants; production behavior and existing contracts remain unchanged.
The suite retains two core cases and the shared helpers, and restores the saved original's fixtures, tables, names, and assertions.

Files
  • apps/web/src/lib/github-pr-review/context-issues.test.ts — Modified test file (+240/-0 lines). Restores both removal event pairs, both endpoint directions, relationship categories, and directed keys. Covers unrelated issues, other pull requests, null or deleted endpoints, malformed issues, and invalid or unordered timestamps. Checks independent cursors beyond 100 entries, failed pages, repeated cursors, null pages, changed counts, and the shared deadline. Checks historical evidence, successful siblings, denial versus transient failures, retry metadata, issue identity, and the available sibling URL when a link is missing.

Tests: 1 file modified — context-issues.test.ts; 30 cases restored, 32 total cases, and 24 assertion sites.
Generated: 0 files changed.


Visual Changes

Visual Changes: N/A

Verification

No manual tests ran because this level changes tests only; live backend and iOS verification will run on the completed stack tip.

Reviewer Notes

Scope

  • Repository: Kilo-Org/cloud; worktree: /Users/igor/Projects/.worktrees/mobile-pr-review-context-5458.
  • This description covers level 13 only, from mobile-pr-review-context-5458-s12 to mobile-pr-review-context-5458-s13.

Supplied automated evidence

  • Jest passed all 32 cases in one suite; comparison with the saved original found no differences.
  • The launcher used the repository configuration with runInBand, omitted globalSetup and setupFilesAfterEnv, and disabled caching.
  • Omitting setup prevented environment reads and database resets; Jest artifacts used the approved temporary directory.
  • Oxlint reported zero warnings and errors; formatting and whitespace checks passed.

The current round did not rerun router or schema suites, repository-wide tests, type checks, or builds.
Provider comparisons, mobile behavior, fixture validation, and live runtime verification remain outside this level's evidence.

Human steps

No human steps are required before merge or after merge.

Notes

This level adds linked-issue regression tests only. Live backend and iOS verification will run on the completed stack tip.

Stacked PRs — merge bottom to top. Each level shows only its own diff.

Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.

  1. mobile-pr-review-context-5458-s1 — ci(pr-review): enable checks for context stack bases #5679
  2. mobile-pr-review-context-5458-s2 — feat(pr-review): define source-backed context contracts #5682
  3. mobile-pr-review-context-5458-s3 — feat(pr-review): normalize optional context payloads #5684
  4. mobile-pr-review-context-5458-s4 — feat(pr-review): map available REST context metadata #5687
  5. mobile-pr-review-context-5458-s5 — feat(pr-review): isolate optional context reads #5690
  6. mobile-pr-review-context-5458-s6 — feat(pr-review): complete labels and requested people #5691
  7. mobile-pr-review-context-5458-s7 — feat(pr-review): define review source documents and normalization #5695
  8. mobile-pr-review-context-5458-s8 — feat(pr-review): select source-backed review decisions #5696
  9. mobile-pr-review-context-5458-s9 — feat(pr-review): integrate independent review context reads #5699
  10. mobile-pr-review-context-5458-s10 — test(pr-review): preserve review source failure coverage #5703
  11. mobile-pr-review-context-5458-s11 — feat(pr-review): define linked issue source contracts #5706
  12. mobile-pr-review-context-5458-s12 — feat(pr-review): integrate typed linked issue context #5707
  13. mobile-pr-review-context-5458-s13 — test(pr-review): cover linked issue source failures #5708 ← this PR
  14. mobile-pr-review-context-5458-s14 — feat(pr-review): preserve structured policy evidence #5709
  15. mobile-pr-review-context-5458-s15 — feat(pr-review): normalize applicable merge policies #5712
  16. mobile-pr-review-context-5458-s16 — feat(pr-review): read applicable merge policies #5713
  17. mobile-pr-review-context-5458-s17 — feat(pr-review): define requirement observation contracts #5720
  18. mobile-pr-review-context-5458-s18 — feat(pr-review): expand named policy requirements #5723
  19. mobile-pr-review-context-5458-s19 — feat(pr-review): evaluate evidenced check requirements #5727
  20. mobile-pr-review-context-5458-s20 — feat(pr-review): evaluate evidenced merge policies #5728
  21. mobile-pr-review-context-5458-s21 — test(pr-review): preserve check evaluation coverage #5730
  22. mobile-pr-review-context-5458-s22 — test(pr-review): preserve policy evaluation coverage #5732
  23. mobile-pr-review-context-5458-s23 — feat(pr-review): integrate requirement observation reads #5735
  24. mobile-pr-review-context-5458-s24 — test(pr-review): preserve requirement source coverage #5736
  25. mobile-pr-review-context-5458-s25 — test(pr-review): complete requirement reader coverage #5739
  26. mobile-pr-review-context-5458-s26 — feat(pr-review): preserve queue membership and position #5741
  27. mobile-pr-review-context-5458-s27 — refactor(pr-review): share mobile-safe context contracts #5744 (tip)

@kilo-code-bot

kilo-code-bot Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • apps/web/src/lib/github-pr-review/context-issues.test.ts

Reviewed by grok-4.6 · Input: 106K · Output: 21.1K · Cached: 443.4K

Review guidance: REVIEW.md from base branch mobile-pr-review-context-5458-s12

@iscekic

iscekic commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Closing: the owner stopped this workflow section. The branch is retained.

@iscekic iscekic closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant