Skip to content

i18n(ja): fix unmatched full-width parentheses - #23989

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-unmatched-parentheses
Sep 30, 2026
Merged

qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-unmatched-parentheses

Conversation

@yahonda

@yahonda yahonda commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes unmatched full-width parentheses (( without ), or ) without () at 54 sites in 48 files. The sites were found by a per-line scan of the whole JA corpus that skips fenced and inline code. Each site was checked against the EN source.

The most common case is a parenthetical example whose closing ) was dropped right after an inline code span, for example (例: `man mkfs.ext4`を参照 → (例: `man mkfs.ext4`)を参照.

Other cases:

  • Stray ) in two headings: ticdc/ticdc-changefeed-config.md (v8.5.4の新機能), v7.5.0の新機能)) and tidb-configuration-file.md (constraint-check-in-place-pessimistic)). Their explicit {#...} anchors do not change. Also removed a stray ) in literal-values.md.
  • Missing ( in partitioned-table.md, pd-configuration-file.md, sql-prepared-plan-cache.md, dm/dm-best-practices.md, and releases/release-7.6.0.md (L318).

Some parentheticals were also scrambled, and a few swapped what the sentence says:

  • sql-mode.md (ERROR_FOR_DIVISION_BY_ZERO): the JA said "division by INSERT in UPDATE in data-change operations (0 or ...". EN: "division by 0 in data-change operations (INSERT or UPDATE)". Restored the correct order.
  • enable-tls-between-clients-and-servers.md: CREATE USER, ALTER USER, and REQUIRE SSL were rotated. The JA said to specify ALTER USER when creating a user (REQUIRE SSL). EN: specify REQUIRE SSL when you create a user (CREATE USER) or modify one (ALTER USER).
  • ticdc/ticdc-bidirectional-replication.md: the three example links were split around the verb, so it read "has TiDB B <-> TiDB C that connects to ...". Rebuilt it from EN.
  • ticdc/ticdc-data-replication-capabilities.md: the index-operations bullet was garbled (it read "if the downstream is TiDB, TiCDC [asynchronously executes ...]"). Rebuilt it from EN.
  • sql-statements/sql-statement-set-role.md: restored を in "set 'r1'@'%' as the default role".
  • ticdc/ticdc-faq.md, storage-engine/titan-configuration.md, dm/dm-customized-secret-key.md, tidb-cloud/serverless-limitations.md, faq/sql-faq.md, sql-statements/sql-statement-show-stats-histograms.md, command-line-flags-for-pd-configuration.md: reordered the sentence so that the parenthetical attaches to what EN attaches it to. For example, ticdc/ticdc-faq.md now says "the default 24 hours of gc-ttl", not "the default 24 hours (gc-ttl".
  • releases/release-7.6.0.md (L478): "in upstream" was rendered as an unclosed (アップストリーム before the issue link. It is now part of the sentence.
  • tidb-cloud/connected-*.md (3 files): the unclosed ( came with a nested <a href="mailto:...">[support@pingcap.com](mailto:...)</a> and, in one file, a stray 電話 ("phone") before an email address. These now match EN: (<a href="mailto:support@pingcap.com">support@pingcap.com</a>).
  • Restored dropped は in upgrade-monitoring-services.md (×2), metadata-lock.md, and sql-prepared-plan-cache.md on the same lines.

Not changed: data-type-string.md. Its VARCHAR length table is fixed in #23991 together with its character set names. metrics-schema.md L92 has a stray (, but it is inherited from EN ("such as (metrics_summary"), so it is fixed on the EN side in #23990.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified guidance for TLS requirements, backup consistency, TiCDC replication and configuration, and TiDB Cloud Starter cluster quotas.
    • Corrected examples and explanations across SQL, deployment, monitoring, migration, and troubleshooting topics.
    • Updated contact links and clarified download URL placeholders.

@ti-chi-bot

ti-chi-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5c49861b-6bb7-4a68-af0c-e1e9fa6ef135

📥 Commits

Reviewing files that changed from the base of the PR and between 68a2407 and 5cfbe73.

📒 Files selected for processing (6)
  • sql-statements/sql-statement-show-stats-histograms.md
  • ticdc/ticdc-bidirectional-replication.md
  • tidb-cloud/connected-ai-chat-in-im.md
  • tidb-cloud/serverless-limitations.md
  • tidb-troubleshooting-map.md
  • tiup/tiup-cluster-topology-reference.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

This PR corrects wording, punctuation, examples, and links across documentation. It also clarifies existing descriptions for SQL behavior, DM and TiCDC replication, configuration, and TiDB Cloud limits. No implementation changes are shown.

Changes

Database, SQL, and configuration documentation

Layer / File(s) Summary
Database, SQL, and configuration documentation
auto-random.md, benchmark/online-workloads-and-add-index-operations.md, command-line-flags-for-pd-configuration.md, command-line-flags-for-tikv-configuration.md, data-type-date-and-time.md, enable-tls-between-clients-and-servers.md, faq/backup-and-restore-faq.md, faq/sql-faq.md, global-indexes.md, literal-values.md, metadata-lock.md, partitioned-table.md, pd-configuration-file.md, performance-tuning-overview.md, releases/release-7.6.0.md, sql-mode.md, sql-prepared-plan-cache.md, sql-statements/*, storage-engine/titan-configuration.md, tidb-configuration-file.md, tidb-troubleshooting-map.md
Corrects punctuation and examples, and clarifies descriptions of SQL behavior, configuration, and release-note conditions.
DM and TiCDC documentation
dm/dm-best-practices.md, dm/dm-customized-secret-key.md, releases/release-7.6.0.md, ticdc/*
Corrects DM and TiCDC examples and wording. Clarifies replication constraints, configuration guidance, and descriptions of replication behavior.
TiDB Cloud documentation
tidb-cloud/connected-ai-chat-in-im.md, tidb-cloud/connected-lark-ticket-creation.md, tidb-cloud/connected-lark-ticket-interaction.md, tidb-cloud/data-service-manage-endpoint.md, tidb-cloud/migrate-incremental-data-from-mysql-using-data-migration.md, tidb-cloud/monitor-alert-zoom.md, tidb-cloud/serverless-limitations.md
Corrects support email links and examples, and clarifies the Starter cluster limit and related requirements.
Operations and TiUP documentation
grafana-performance-overview-dashboard.md, tiup/tiup-cluster-topology-reference.md, tiup/tiup-command-mirror-genkey.md, tiup/tiup-command-mirror-sign.md, tiup/tiup-component-dm-upgrade.md, tune-operating-system.md, upgrade-monitoring-services.md
Corrects examples and descriptions in monitoring, operating system, and TiUP documentation.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Other

Suggested reviewers: qiancai

Merge Risk: ⚪ Minimal · up to 5cfbe

The updated guidance clearly states the two separate setup steps, resolving the prior ambiguity. No actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 5cfbe

The change affects 27 systems.

Changed systems: ticdc, tidb-cloud, sql-statements, tiup, dm, faq, auto-random.md, benchmark, command-line-flags-for-pd-configuration.md, command-line-flags-for-tikv-configuration.md, data-type-date-and-time.md, enable-tls-between-clients-and-servers.md, global-indexes.md, grafana-performance-overview-dashboard.md, literal-values.md, metadata-lock.md, partitioned-table.md, pd-configuration-file.md, performance-tuning-overview.md, releases, sql-mode.md, sql-prepared-plan-cache.md, storage-engine, tidb-configuration-file.md, tidb-troubleshooting-map.md, tune-operating-system.md, upgrade-monitoring-services.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — ticdc (service) was modified; 9 changed files map to changed impact.
  • observed — tidb-cloud (service) was modified; 7 changed files map to changed impact.
  • observed — sql-statements (service) was modified; 4 changed files map to changed impact.
  • observed — tiup (service) was modified; 4 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in auto-random.md: The shard-bit example now closes the parenthesis around log(2, 16) before introducing its equivalent value, and closes the 4 parenthesis correctly.
  • observed — Modified behavior in benchmark/online-workloads-and-add-index-operations.md: The example retry message now has a closing parenthesis before the text describing where to inspect the retry count.
  • observed — Modified behavior in command-line-flags-for-pd-configuration.md: The --peer-urls guidance now formats the host-IP example as a parenthetical value following the flag name, correcting the previous malformed parentheses; the Docker example remains unchanged.
  • observed — Modified behavior in command-line-flags-for-tikv-configuration.md: Corrected punctuation around the --addr example; the deployment guidance and example addresses are unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: fixing unmatched full-width parentheses in the Japanese documentation.
Description check ✅ Passed The description covers the required change summary, affected TiDB version, related references, AI involvement, and change-category checklist. It provides detailed scope and exclusions, so it is comple…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7f05e2d7-dc77-4449-9d94-7a00f97ba1de

📥 Commits

Reviewing files that changed from the base of the PR and between 6548a64 and 90f3500.

📒 Files selected for processing (50)
  • auto-random.md
  • benchmark/online-workloads-and-add-index-operations.md
  • command-line-flags-for-pd-configuration.md
  • command-line-flags-for-tikv-configuration.md
  • data-type-date-and-time.md
  • data-type-string.md
  • dm/dm-best-practices.md
  • dm/dm-customized-secret-key.md
  • enable-tls-between-clients-and-servers.md
  • faq/backup-and-restore-faq.md
  • faq/sql-faq.md
  • global-indexes.md
  • grafana-performance-overview-dashboard.md
  • literal-values.md
  • metadata-lock.md
  • partitioned-table.md
  • pd-configuration-file.md
  • performance-tuning-overview.md
  • releases/release-7.6.0.md
  • sql-mode.md
  • sql-prepared-plan-cache.md
  • sql-statements/sql-statement-flashback-table.md
  • sql-statements/sql-statement-set-role.md
  • sql-statements/sql-statement-show-stats-histograms.md
  • sql-statements/sql-statement-show-stats-locked.md
  • storage-engine/titan-configuration.md
  • ticdc/ticdc-bidirectional-replication.md
  • ticdc/ticdc-changefeed-config.md
  • ticdc/ticdc-data-replication-capabilities.md
  • ticdc/ticdc-debezium.md
  • ticdc/ticdc-faq.md
  • ticdc/ticdc-server-config.md
  • ticdc/ticdc-sink-to-kafka.md
  • ticdc/ticdc-upstream-downstream-check.md
  • ticdc/troubleshoot-ticdc.md
  • tidb-cloud/connected-ai-chat-in-im.md
  • tidb-cloud/connected-lark-ticket-creation.md
  • tidb-cloud/connected-lark-ticket-interaction.md
  • tidb-cloud/data-service-manage-endpoint.md
  • tidb-cloud/migrate-incremental-data-from-mysql-using-data-migration.md
  • tidb-cloud/monitor-alert-zoom.md
  • tidb-cloud/serverless-limitations.md
  • tidb-configuration-file.md
  • tidb-troubleshooting-map.md
  • tiup/tiup-cluster-topology-reference.md
  • tiup/tiup-command-mirror-genkey.md
  • tiup/tiup-command-mirror-sign.md
  • tiup/tiup-component-dm-upgrade.md
  • tune-operating-system.md
  • upgrade-monitoring-services.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

Comment thread tidb-cloud/serverless-limitations.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 29, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-29 15:55:30.601310128 +0000 UTC m=+725055.826531235: ☑️ agreed by qiancai.

@ti-chi-bot

ti-chi-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

@qiancai: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yahonda and others added 2 commits September 30, 2026 09:09
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ti-chi-bot

ti-chi-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

@qiancai: Your lgtm message is repeated, so it is ignored.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai
qiancai merged commit 86b29ec into pingcap:i18n-ja-release-8.5 Sep 30, 2026
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants