i18n(ja): fix unmatched full-width parentheses - #23989
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: pingcap/docs/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThis PR corrects wording, punctuation, examples, and links across documentation. It also clarifies existing descriptions for SQL behavior, DM and TiCDC replication, configuration, and TiDB Cloud limits. No implementation changes are shown. ChangesDatabase, SQL, and configuration documentation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The updated guidance clearly states the two separate setup steps, resolving the prior ambiguity. No actionable merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 27 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: pingcap/docs/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 7f05e2d7-dc77-4449-9d94-7a00f97ba1de
📒 Files selected for processing (50)
auto-random.mdbenchmark/online-workloads-and-add-index-operations.mdcommand-line-flags-for-pd-configuration.mdcommand-line-flags-for-tikv-configuration.mddata-type-date-and-time.mddata-type-string.mddm/dm-best-practices.mddm/dm-customized-secret-key.mdenable-tls-between-clients-and-servers.mdfaq/backup-and-restore-faq.mdfaq/sql-faq.mdglobal-indexes.mdgrafana-performance-overview-dashboard.mdliteral-values.mdmetadata-lock.mdpartitioned-table.mdpd-configuration-file.mdperformance-tuning-overview.mdreleases/release-7.6.0.mdsql-mode.mdsql-prepared-plan-cache.mdsql-statements/sql-statement-flashback-table.mdsql-statements/sql-statement-set-role.mdsql-statements/sql-statement-show-stats-histograms.mdsql-statements/sql-statement-show-stats-locked.mdstorage-engine/titan-configuration.mdticdc/ticdc-bidirectional-replication.mdticdc/ticdc-changefeed-config.mdticdc/ticdc-data-replication-capabilities.mdticdc/ticdc-debezium.mdticdc/ticdc-faq.mdticdc/ticdc-server-config.mdticdc/ticdc-sink-to-kafka.mdticdc/ticdc-upstream-downstream-check.mdticdc/troubleshoot-ticdc.mdtidb-cloud/connected-ai-chat-in-im.mdtidb-cloud/connected-lark-ticket-creation.mdtidb-cloud/connected-lark-ticket-interaction.mdtidb-cloud/data-service-manage-endpoint.mdtidb-cloud/migrate-incremental-data-from-mysql-using-data-migration.mdtidb-cloud/monitor-alert-zoom.mdtidb-cloud/serverless-limitations.mdtidb-configuration-file.mdtidb-troubleshooting-map.mdtiup/tiup-cluster-topology-reference.mdtiup/tiup-command-mirror-genkey.mdtiup/tiup-command-mirror-sign.mdtiup/tiup-component-dm-upgrade.mdtune-operating-system.mdupgrade-monitoring-services.md
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.
[LGTM Timeline notifier]Timeline:
|
|
@qiancai: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8f19d61 to
5cfbe73
Compare
|
@qiancai: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What is changed, added or deleted? (Required)
Fixes unmatched full-width parentheses (( without ), or ) without () at 54 sites in 48 files. The sites were found by a per-line scan of the whole JA corpus that skips fenced and inline code. Each site was checked against the EN source.
The most common case is a parenthetical example whose closing ) was dropped right after an inline code span, for example
(例: `man mkfs.ext4`を参照→(例: `man mkfs.ext4`)を参照.Other cases:
ticdc/ticdc-changefeed-config.md(v8.5.4の新機能),v7.5.0の新機能)) andtidb-configuration-file.md(constraint-check-in-place-pessimistic)). Their explicit{#...}anchors do not change. Also removed a stray ) inliteral-values.md.partitioned-table.md,pd-configuration-file.md,sql-prepared-plan-cache.md,dm/dm-best-practices.md, andreleases/release-7.6.0.md(L318).Some parentheticals were also scrambled, and a few swapped what the sentence says:
sql-mode.md(ERROR_FOR_DIVISION_BY_ZERO): the JA said "division byINSERTinUPDATEin data-change operations (0or ...". EN: "division by0in data-change operations (INSERTorUPDATE)". Restored the correct order.enable-tls-between-clients-and-servers.md:CREATE USER,ALTER USER, andREQUIRE SSLwere rotated. The JA said to specifyALTER USERwhen creating a user (REQUIRE SSL). EN: specifyREQUIRE SSLwhen you create a user (CREATE USER) or modify one (ALTER USER).ticdc/ticdc-bidirectional-replication.md: the three example links were split around the verb, so it read "hasTiDB B <-> TiDB Cthat connects to ...". Rebuilt it from EN.ticdc/ticdc-data-replication-capabilities.md: the index-operations bullet was garbled (it read "if the downstream is TiDB, TiCDC [asynchronously executes ...]"). Rebuilt it from EN.sql-statements/sql-statement-set-role.md: restored を in "set'r1'@'%'as the default role".ticdc/ticdc-faq.md,storage-engine/titan-configuration.md,dm/dm-customized-secret-key.md,tidb-cloud/serverless-limitations.md,faq/sql-faq.md,sql-statements/sql-statement-show-stats-histograms.md,command-line-flags-for-pd-configuration.md: reordered the sentence so that the parenthetical attaches to what EN attaches it to. For example,ticdc/ticdc-faq.mdnow says "the default 24 hours ofgc-ttl", not "the default 24 hours (gc-ttl".releases/release-7.6.0.md(L478): "in upstream" was rendered as an unclosed (アップストリーム before the issue link. It is now part of the sentence.tidb-cloud/connected-*.md(3 files): the unclosed ( came with a nested<a href="mailto:...">[support@pingcap.com](mailto:...)</a>and, in one file, a stray 電話 ("phone") before an email address. These now match EN:(<a href="mailto:support@pingcap.com">support@pingcap.com</a>).upgrade-monitoring-services.md(×2),metadata-lock.md, andsql-prepared-plan-cache.mdon the same lines.Not changed:
data-type-string.md. Its VARCHAR length table is fixed in #23991 together with its character set names.metrics-schema.mdL92 has a stray(, but it is inherited from EN ("such as (metrics_summary"), so it is fixed on the EN side in #23990.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit